libostree: remove OSTREE_SUPPRESS_SYNCFS
authorEtienne Champetier <e.champetier@ateme.com>
Tue, 26 Aug 2025 13:10:21 +0000 (09:10 -0400)
committerEtienne Champetier <e.champetier@ateme.com>
Tue, 26 Aug 2025 13:10:21 +0000 (09:10 -0400)
This workaround was needed for the old valgrind version in EL 7

src/libostree/ostree-repo.c
tests/libtest.sh

index 3f2f0419d5cf3349273a73e6f27d1bf5bd69a079..cf48f94d1462ab0cfaf07f3e67814d6ef2d90cfc 100644 (file)
@@ -1527,11 +1527,6 @@ _ostree_repo_syncfs (OstreeRepo *self, GError **error)
 
   if (self->disable_fsync)
     return TRUE;
-  /* FIXME: Added OSTREE_SUPPRESS_SYNCFS since valgrind in el7 doesn't know
-   * about `syncfs`...we should delete this later.
-   */
-  if (g_getenv ("OSTREE_SUPPRESS_SYNCFS") != NULL)
-    return TRUE;
 
   gboolean is_system = ostree_repo_is_system (self);
   if (is_system)
index f8284101f7c8f27997444bc66593f99ad6f4f6a2..24125b2fe106ac75f60fb337639981fcc624d856 100755 (executable)
@@ -180,7 +180,7 @@ fi
 
 CMD_PREFIX=""
 if test -n "${OT_TESTS_VALGRIND:-}"; then
-    CMD_PREFIX="env G_SLICE=always-malloc OSTREE_SUPPRESS_SYNCFS=1 valgrind -q --error-exitcode=1 --leak-check=full --num-callers=30 --suppressions=${test_srcdir}/glib.supp --suppressions=${test_srcdir}/ostree.supp"
+    CMD_PREFIX="env G_SLICE=always-malloc valgrind -q --error-exitcode=1 --leak-check=full --num-callers=30 --suppressions=${test_srcdir}/glib.supp --suppressions=${test_srcdir}/ostree.supp"
 fi
 
 if test -z "${OSTREE_HTTPD:-}"; then